nachomazzara

Sorted-Collection

SortedList.sol

High vulnerability

• DoS when the list has more than ~5527 items. Every time the median is calculated, it loops through the entire list to get the size and then loop size / 2 to get the median itself. Consider storing and update the size of the list every time the user insert or remove a node along with the two nodes which are part of the median in the struct. The worst scenario for an insert could be n - 1 loop where n is the size of the list. Consider using a binary search in order to reduce as much as possible a possible DoS.

Medium vulnerability

nachomazzara

Defswap Audit

DefswapFactory

Low vulneravility

• Exchange could be created with address 0.

• Consider index _token address at CreatedExchange event for traceability.

nachomazzara

Collateral - Security Audit

Table of contest

• Introduction
• General Notes
• Specifications
• Contracts
  • CollateralAuctionCallback.sol
• CollateralHandler.sol

nachomazzara

AsyncArt v2 - Security Audit

Table of contest

• Introduction
• Contracts
  • AsyncArtwork_v2.sol
  • TokenUpgrader.sol

Introduction

nachomazzara

Arcadeum - Security Audit

Table of contest

• Introduction
• Contracts
  • TieredOwnable.sol
  • BridgeFactory.sol
  • FreemintFactory.sol
• Conquest.sol

nachomazzara

Livepeer - LIP-25 - Security Review

Introduction

Livepeer team requested the LIP-25 proposal revision by auditing the Governor smart contract, the commit referenced for this audit is ac98605f78520b0ef43e31d0d20d0efbf2d32876.

Governor.sol

To take into consideration

• Based on how each update is staged, if for some reason two calls are needed within a delay, the second one will fail. Even it is not part of the spec, a common usage as set regular payments won't be possible. This could be allowed by using a nonce allowing the same call to be staged more than once.

nachomazzara

Fee & Burner - Security Review

Table of contest

• Introduction
• Contracts
  • DebtEngine.sol
  • BurnerConverter.sol

Introduction

nachomazzara

TokenSpender - Security Review

Table of contest

• Introduction
• Contract
  • TokenSpender.sol

Introduction

nachomazzara

Tradestars - Security Review

Table of contest

• Introduction
• Repository
  • tradestars-token
    • TokenVesting.sol
    • TransferWithSigERC20.sol
• LibTokenTransferOrder.sol

nachomazzara

MerkleProfitSharing - Security Review

Table of contest

• Introduction
• Repository
• MerkleProfitSharing.sol

Introduction