Skip to content

Instantly share code, notes, and snippets.

@rsmelo92
Last active January 13, 2020 15:13
Show Gist options
  • Save rsmelo92/687489bacf191e8c7e970e2430dc0761 to your computer and use it in GitHub Desktop.
Save rsmelo92/687489bacf191e8c7e970e2430dc0761 to your computer and use it in GitHub Desktop.
// *SMELL*
function ballSports() {
const playersTypes = [
{name: "soccerPlayers", usesFeet: true, usesHands: false},
{name: "basketPlayers", usesFeet: false, usesHands: true},
{name: "volleyPlayers", usesFeet: false, usesHands: true},
{name: "hockeyPlayers", usesFeet: false, usesHands: false}
// WHAT IF WE NEED TO ADD {name: "baseballPlayers", usesFeet: false, usesHands: false} ?
];
return playersTypes.filter(players => {
if (players.usesFeet || players.usesHands) {
return players;
}
})
}
// *REFACTORED*
function ballSports() {
const playersTypes = [
{name: "soccerPlayers", usesFeet: true, usesHands: false, usesRoundObject: true},
{name: "basketPlayers", usesFeet: false, usesHands: true, usesRoundObject: true},
{name: "volleyPlayers", usesFeet: false, usesHands: true, usesRoundObject: true},
{name: "hockeyPlayers", usesFeet: false, usesHands: false, usesRoundObject: false},
{name: "baseballPlayers", usesFeet: false, usesHands: false, usesRoundObject: true}
];
return playersTypes.filter(players => {
if (players.usesRoundObject) {
return players;
}
})
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment