Skip to content

Instantly share code, notes, and snippets.

@sloria
Last active March 5, 2019 17:27
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save sloria/5895679 to your computer and use it in GitHub Desktop.
Save sloria/5895679 to your computer and use it in GitHub Desktop.
class Point:
def __init__(self, x, y):
self.x, self.y = x, y
@classmethod
def polar(cls, r, theta):
return cls(r * cos(theta),
r * sin(theta))
point = Point.polar(r=13, theta=22.6)
@gmjosack
Copy link

theta=22.6

@cbg
Copy link

cbg commented Feb 28, 2014

(Looks like the gist comment doesn't want to preserve my spacing). Suggestion: Line up the r * sin(theta) under r * cos(theta)
to conform to PEP 8.

@dhaffner
Copy link

The arguments for polar should be named (line 6) to match the call on line 10. Better yet, the call on line 10 should be changed to have positional arguments so that it matches the original constructor for Point

@ludat
Copy link

ludat commented Feb 28, 2014

missed one underscore on the second line

@sloria
Copy link
Author

sloria commented Feb 28, 2014

Fixed. Thanks for the suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment