Refactored mailer methods

UserMailer.rb

# This is an exercise in refactoring. The attempt is to make the code more DRY (Don't Repeat Yourself) while 
# maintaining or increasing readability. While it's certainly more DRY, readability seems to have suffered.
# Therefore, this may be a case where less DRY code is ultimately better for the project and future devs.

  def report_email(user, report, template_name)
    @user   = user
    @report = report
    mail(to: @user.email,
         from: "\"Company Reports\" reports@example.com",
         subject: "#{template_name.chomp('_email').humanize} for #{@user.account.name}",
         template_name: template_name)
  end

  def rating_email(user, rating, template_name)
    @user   = user
    @rating = rating
    mail(to: @user.email,
         from: "\"Company Alerts\" alerts@example.com",
         subject: "#{template_name.chomp('_email').humanize} for #{@user.account.name}",
         template_name: template_name)
  end

# REFACTORED TO ONE METHOD:

  def report_or_alert_email(user, object, template_name)
    @user = user
    @object = object
    # Ensure the instance vars in the mailer templates are changed accordingly
    @template_name = template_name
    mail(to: @user.email,
         from: sent_from,
         subject: email_subject,
         template_name: template_name)
  end

  private

  def sent_from
    "\"Company #{class_name.capitalize.pluralize}\" #{class_name.downcase.pluralize}@example.com"
    # => example: "Company Reports" reports@company.com
  end

  def class_name
    @object.class.to_s
  end

  def email_subject
    "#{@template_name.chomp('_email').humanize} for #{@user.account.name}"
    # => example: "Week Report for Cooper Account"
  end