Skip to content

Instantly share code, notes, and snippets.

@wimleers
Last active October 25, 2018 08:43
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save wimleers/3c15debe900ab5018fead601b19c4bc4 to your computer and use it in GitHub Desktop.
Save wimleers/3c15debe900ab5018fead601b19c4bc4 to your computer and use it in GitHub Desktop.

Mateu, Gabe and I just released the first RC of JSON API 2, so time for an update!

It's been three months since the previous "state of JSON API" blog post, where we explained why JSON API didn't get into Drupal 8.6 core.

What happened since then? In a nutshell:

  • We're now much closer to getting JSON API into Drupal core!
  • JSON API 2.0-beta1, 2.0-beta2 and 2.0-rc1 were released
  • Those three releases span 84 fixed issues. (Not counting support requests.)
  • includes are now 3 times faster, 4xx responses are now cached!
  • Fixed all spec compliance issues mentioned previously
  • Zero known bugs (the only two open bugs are core bugs)
  • Only 10 remaining tasks (most of which are for test coverage in obscure cases)
  • ~75% of the open issues are feature requests!
  • ~200 sites using the beta!
  • Also new: JSON API Extras 2.10, works with JSON API 1.x & 2.x!
  • Two important features are >80% done: file uploads & revisions (they will ship in a release after 2.0)

So … now is the time to update to 2.0-RC1!

JSON API spec v1.1

We've also helped shape the upcoming 1.1 update to the JSON API spec, which we especially care about because it allows a JSON API server to use "profiles" to communicate support for capabilities outside the scope of the spec. 1

Retrospective

Now that we've reached a major milestone, I thought it'd be interesting to do a small retrospective using the project page's sparklines:

JSON API project statistics, annotated with green vertical lines for the start of 2018 and the time of the previous blog post.

The first green line indicates the start of 2018. Long-time Drupal & JSON API contributor Gabe Sullice joined Acquia's Office of the CTO two weeks before 2018 started. He was hired specifically to help push forward the API-First initiative. Upon joining, he immediately started contributing to the JSON API module, and I joined him shortly thereafter. (Yes, Acquia is putting its money where its mouth is.)
The response rate for this module has always been very good, thanks to original maintainer Mateu "e0ipso" Aguiló Bosch working on it quite a lot in his sparse free time. (And some company time — thanks Lullabot!) But there's of course a limit to how much of your free time you can contribute to open source.

  • The primary objective for Gabe and I for most of 2018 has been to get JSON API ready to move into Drupal core. We scrutinized every area of the existing JSON API module, filed lots of issues, minimized the API surface, maximized spec compliance (hence also minimizing Drupalisms), minimized potential for regressions to occur, and so on. This explains the significantly elevated rate of the new issues sparkline. It also explains why the open bugs sparkline first increased.
  • This being our primary objective also explains the response rate sparkline being at 100% nearly continously. It also explains the plummeted average first response time: it went from days to hours! This surely benefited the sites using JSON API: bug fixes happened much faster.
  • By the end of June, we managed to make the 1.x branch maximally stable and mature in the 1.22 release (shortly before the second green vertical line) — hence the "open bugs" sparkline decreased). The remaining problems required BC breaks — usually minor ones, but BC breaks nonetheless! The version of JSON API that ends up in core needs to be as future proof as possible: BC breaks are not acceptable in core. 2 Hence the need for a 2.x branch.

Surely the increased development rate has helped JSON API reached a strong level of stability and maturity faster, and I believe this is also reflected in its adoption: a 50–70 percent increase since the end of 2017!

From 1 to 3 maintainers

This was the first time I've worked so closely and so actively on a small codebase in an open-source setting. I've learned some things.

Some of you might understandably think that Gabe and I steamrolled this module. But Mateu is still very actively involved, and every significant change still requires his blessing. Funded contributions have accelerated this module's development, but neither Acquia nor Lullabot ever put any pressure on how it should evolve. It's always been the module maintainers, through debate (and sometimes heartfelt concessions), who have moved this module forward.

The "participants" sparkline being at a slightly higher level than before (with more consistency!) speaks for itself. Probably more importantly: if you're wondering how the original maintainer Mateu feels about this, I'll be perfectly honest: it's been frustrating at times for him — but so it's been for Gabe and I — for everybody! Differences in availability, opinion, priorities (and private life circumstances!) all have effects. When we disagree, we meet face to face to chat about it openly.

In the end I still think it's worth it though: Mateu has deeper ties to concrete complex projects, I have deeper ties to Drupal core requirements, and Gabe sits in between those extremes. Our discussions and disagreements force us to build consensus, which makes for a better, more balanced end result! And that's what open source is all about: meeting the needs of more people better :)

API-first Drupal with multiple consumers @DrupalConNA :D pic.twitter.com/GhgY8O5SSa

— Gábor Hojtsy (@gaborhojtsy) April 11, 2018
<script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>

Footnotes

  1. The spec does not specify how filtering and pagination should work exactly, so the Drupal JSON API implementation will have to specify how it handles this exactly.

  2. I've learned the hard way how frustratingly sisyphean it can be to stabilize a core module where future evolvability and maintainability were not fully thought through.

@e0ipso
Copy link

e0ipso commented Oct 25, 2018

Some of you might understandably think that Gabe and I steamrolled this module. But Mateu is still very actively involved, and every significant change still requires his blessing.

I'd add: funded contributions have been the engine of improvement in the module, however not Acquia nor Lullabot ever put any pressures on how the module should evolve. It's always been the module maintainers, through debate (and sometimes heartfelt concessions), who have moved this module forward.

I'm not 💯 happy about the phrasing, but I'm sure you understand the sentiment I want to convey @wimleers.

@e0ipso
Copy link

e0ipso commented Oct 25, 2018

Our discussions and disagreements force us to build consensus, which makes for a better, more balanced end result! And that's what open source is all about: meeting the needs of more people better :)

… and when we disagree, we meet face to face to chat about it openly

@wimleers
Copy link
Author

@e0ipso: incorporated both of those! Also moved the embedded tweet/image down to the bottom, to show the team right after talking about it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment