Skip to content

Instantly share code, notes, and snippets.

View yashasvigirdhar's full-sized avatar

Yashasvi yashasvigirdhar

  • Google
  • London
View GitHub Profile
@yashasvigirdhar
yashasvigirdhar / AndroidJavaCodeReview.md
Created July 25, 2016 18:37 — forked from srivastavarobin/AndroidJavaCodeReview.md
Code Review Checklist for Android (Java Only)

My Android Java Code Review Checklist

  1. Is the functionality correct?
  2. Are the classes named suitably?
  3. Are the functions named suitably?
  4. How's the datastructure being used? Is it the correct DS or it needs improvement?
  5. Can the classes be further borken into small classes?
  6. Do we need an interface?
  7. If it contain functions that can be reused later then are there Utils created for them?
  8. Can it use already available Util functions?
  9. Does the large set of input for a function deserve a new bean to be created?