Create a gist now

Instantly share code, notes, and snippets.

@acdlite /app.js
Last active Apr 28, 2017

What would you like to do?
Quick and dirty code splitting with React Router v4
// getComponent is a function that returns a promise for a component
// It will not be called until the first mount
function asyncComponent(getComponent) {
return class AsyncComponent extends React.Component {
static Component = null;
state = { Component: AsyncComponent.Component };
componentWillMount() {
if (!this.state.Component) {
getComponent().then(Component => {
AsyncComponent.Component = Component
this.setState({ Component })
render() {
const { Component } = this.state
if (Component) {
return <Component {...this.props} />
return null
const Foo = asyncComponent(() =>
System.import('./Foo').then(module => module.default)
const Bar = asyncComponent(() =>
System.import('./Bar').then(module => module.default)
const App = () =>
<Link to="/foo">Foo</Link>
<Link to="/bar">Bar</Link>
<Match pattern="/foo" component={Foo} />
<Match pattern="/bar" component={Bar} />
export default App
mhaagens commented Oct 5, 2016

Thanks so much for this! Would you happen to know a good way to be able to pass in props to the component? I.E. I used to be able to do render={(props) => <Home {...props} store={store} />}.

lourd commented Oct 5, 2016

Instead of using the component prop for Match, use render or children.

mcku commented Oct 11, 2016 edited

Thanks, this was very helpful. I am still on webpack 1, therefore stick with require.ensure instead of System.import. Addition of a wrapper around require.ensure helps async loading of modules, as shown on this link.

Using it with React Router v4 and it's fine.

Just came across this. Nice. :)

I created a lib to help. Similar in concept, but different.


How could I animate transitions when using asyncComponent for pages?

gutenye commented Dec 4, 2016 edited

@acdlite How do you handle system.import problem with nested routes? webpack/webpack-dev-server#333


<Match pattern="/foo/bar" component={Bar} />

Will get GET http://localhost:3000/foo/ 404 not found error. The correct path should be http://localhost:3003/

btnwtn commented Jan 6, 2017

Should this now use require.ensure instead of System.import?

I think this solution is elegant but too complicated to implement (same for the code-split-component solution...), I still don't get why react-router 4 won't handle the async routes on the server-side...

cescoferraro commented Jan 19, 2017 edited

@acdlite does not work for me unless I type the extensions.

const Foo = asyncComponent(() =>
  System.import('./Foo.tsx').then(module => module.default)

My problem is that I am using server side rendering, then on the server I require component A. on the client I System.import component A.
So when I access the lazy loaded route I get this react reuse markup warning because the client rendered
null from
while loading Component A.

Warning: React attempted to reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server:
(client) CO 0.0.0<!-- react-empty: 6 -
(server) CO 0.0.0<div data-radium="tru

How can I make this work without errors?

cescoferraro commented Jan 29, 2017 edited


For server side rendering the AsyncComponent has a diferrent behaviour on the server than on the client.

On the client, the asyncomponent always return null for the first time, than it finds/loads the component itself on the second time it renders.

But on the server it will only return null on the first request! On the second request the server already know where the code splitted bundle is and immediatly return the component. Making react angry and complaining abour reused markup.

A workaround is quite simple. asyncComponent has to always return null/(whatever you want) at server side. But this is not search engine friendly and I miss the whole point of server render

        let isServer = () => !(typeof window !== "undefined" && window.document);
        render() {
            let spinner = <br/>;
            if (isServer()) {
                return spinner;
            const {Component} = this.state;

            if (Component !== null) {
                console.log("returning actual component ");
                return <Component {...this.props} />;
            return spinner; //with a loading spinner, etc..

Thanks, very helpful :)

mrmckeb commented Mar 7, 2017 edited

@acdlite What's the reason that you're checking if (!this.state.Component)on line 9? Wouldn't it always be null on mount, or am I missing something here?

Great work on this BTW, very helpful.

edorivai commented Mar 9, 2017

@mrmckeb The state is initialize with the static value AsyncComponent.Component, which is null initially, but is set to the loaded component on line 11: AsyncComponent.Component = Component. The second time this component is rendered, state.Component will be initialized with the static value, therefore the loading can be skipped.

seefeld commented Mar 11, 2017 edited


@acdlite I get the following error message, any suggest for it?

Warning: setState(...): Can only update a mounting component. This usually means you called setState() outside componentWillMount() on the server. This is a no-op. Please check the code for the AsyncComponent component.

thank you :)

How would you go about tackling nested routes without having System.import for each of them? What if I wanted to group a couple of routes and have the parent load the bundle? Because component={} would require a loaded reference I'm having difficulty getting this to work, and out of the box V4 does not support the asynchronous loading of routes so that I could load them in from the bundle.

Having trouble wrapping my head around this one :) most examples only have basic routes like /about, but what if you wanted /user, and /user/:id, and /user/:id/contact let's say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment