Skip to content

Instantly share code, notes, and snippets.

@khalidwilliams

khalidwilliams/2005 Final Project submission.md

Created September 21, 2020 17:53
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save khalidwilliams/aa1e67343809897a14836750d1bc4c13 to your computer and use it in GitHub Desktop.
Save khalidwilliams/aa1e67343809897a14836750d1bc4c13 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
2005 Final Project submission.md

Final Project Submission

Rocky Balboa victoriously cheering

You did it!! Congratulations on getting through the Mod 3 projects.

There are a lot of y'all, and not a lot of time to give detailed feedback on every piece of all your projects. So please commetns down below with the link to your repo, the link to your deployment (if you have one, not stress if not), and 1 - 2 dpecific areas of the code you want feedback on. Thank you, and great work!

@leighlars
Copy link

leighlars commented Sep 21, 2020 •
edited

Repo || Deployed Page || Youtube Walk-through

Super curious how I could have refactored some components, mainly the ItineraryForm & AddButton.
I also want feedback on testing in App.
If you have time, I worked hard on the UX and want feedback. I'd eventually like to build a server and actually use this site for myself + family, but want to see areas I could improve or features a user could want.

@rwilliams659
Copy link

rwilliams659 commented Sep 21, 2020 •
edited

Repo - I'd love feedback on implementation of Router, and overall component architecture.

@GreysonElkins
Copy link

Repo - I'd dig feedback on async testing, specifically in App and ApiHelper. Thanks y'all!

@AurumValian
Copy link

Repo - I'd like some feedback on my App tests and component structure. Thanks!

@ErinUntermeyer
Copy link

Repo
Deployed
I'd love some feedback on using Router in the BreweryDetails component.
Thanks!

@relyt4me
Copy link

relyt4me commented Sep 21, 2020 •
edited

Repo
Deployed
I would like feedback on my Integration testing

@NakiNorton
Copy link

Repo
I would love some feedback on componentDidMount in App... specifically, is the way I structured it making the app load super slow?

@tarynmartin
Copy link

repo
I'd love feedback on TriviaCard vs. GameCard, was there a better way of handling it?
And any and all feedback on testing would be appreciated

@H-Bo214
Copy link

H-Bo214 commented Sep 21, 2020

Repo

I would like feedback on Integration testing and the way I used DetailsPage in conjunction with FavoritesPage.

@kip-west
Copy link

Repo
I'd like some feedback with my testing; I felt unsure about how to do acceptance level testing given how my app interacts with the backend.

@carlymclift
Copy link

carlymclift commented Sep 22, 2020 •
edited

Repo
I'd love feedback on testing!

@MarchCorbin
Copy link

SWAPP REPO
Feedback on testing and file structure would be appreciated.

@amykarnaze
Copy link

https://github.com/amykarnaze/Plants
Testing, please!

@Leasw144
Copy link

Repo
mocking in integration testing and code structure please

@NicoleLatifi
Copy link

NicoleLatifi commented Sep 22, 2020 •
edited

Repo

I would appreciate feedback on error handling and structure of button components.

@jordy1611
Copy link

Stargazer Repo

I had some issues with App testing because of jest.useFakeTimers() & jest.runAllTimers()
Basically was creating multiple virtual DOMs each time use a render

@nickhartdev
Copy link

Repo

Would love feedback on architecture decisions, as well as some bizarre warnings I was getting from my tests despite them passing.

@Abdeboskey
Copy link

Sluggish Activity

  • I would appreciate feedback on the component architecture and the test coverage of the application.
    Thank you!

@JoshSevy
Copy link

VisualFox
Would love feedback on routing tips and always testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment