2006 final project submission.md

Final Project Submission

You did it!! Congratulations on getting through the Mod 3 projects.

There are a lot of y'all, and not a lot of time to give detailed feedback on every piece of all your projects. So please comment down below with

• the link to your repo
• the link to your deployment (if you have one, not stress if not)
• 1 - 2 dpecific areas of the code you want feedback on.

Thank you, and great work!

• Repo
• use of hooks - had to use conditional rendering sometimes instead of creating more hooks - not sure which is better?
• how GET requests are formatted for comparing cities

• Don't Fear the Repo
• How to refactor the last test in App (tried to use map but ran into a ton of errors)
• Data flow

link

• test layouts (is there too much in each it block?)
• Are ternaries acceptable in return statements?

Repo link

Deployed site

• userEvent and async testing
• Hoping the use of functional components over class based-based components for everything other than App is acceptable. Specifcally in the case of Search.
• Also if you have the time, are my font imports the right convention?

You Repo What You Sow

• My App integration test. How can I test a user story without repeating a bunch of code? I just feel like my last it block could have been more succinct.

repo
deployed Site

• testing using async and UserEvent
• use of state

Project repo: https://github.com/nicolegooden/potter
Not yet deployed

1. Are my test suites thorough enough? Would really appreciate a response to some of my comments in my test files!
2. Are my functional components too crowded with conditionals?

Thanks in advance!

Lyrical Lies Repo
Deployed Page - note that audio doesn't work on deployed site for some reason

1. Are my tests thorough and in the correct components?
2. Is the basic architecture a good structure or would you recommend changes? Would you recommend changing the way I use state?

https://github.com/Chriscastanuela/chuck

Testing

https://github.com/krogowsk531/under-the-weather

• Were there components that I may be able to refactor and combine into one?
• Where I should be more thoroughly testing?

Repo: https://github.com/nware1066/pub-menu

sad path testing

Repo

• Testing: are my tests thorough enough?

• Project architecture, could I have been leaner with my components?

Link to Repo
Not Reployed

• Breakdown of logic between components
• Best Practices behavior on state/data down actions up

Repo

• async JS organization and testing

Repo

Testing: specifically, whether it is thorough enough and why my catches are logging in the terminal.
Architecture: Organization and state management

Repo
Deployed

repo
env api key: REACT_APP_API_KEY=FB1509FF-2D29-7C41-AD87-7E52E19A0A22795D51E2-8C6C-4F81-94A1-20C7415D8B7F

1. Is this an acceptable use of router? (specifically the non-exact use of results page if too brief)
2. Data flow

https://github.com/taylorjohnson141/learnlo
Architecture: Is everything set up okay
Testing:Am I testing everything correctly

https://github.com/BrigetteDoelp/wayshrine-adventurer-registry

TESTING PLEASE
and also architecture! had a second guessing moment there, so i'd like to hear about how my react stuff is plz

PokéPlanner

Testing:

• What did I not test that I should have?
• How can I improve the asyn testing?

Data:

• Where the components separated correctly?
• Where the props passed correctly?
• Why are the errors in the console mad at me?