Skip to content

Instantly share code, notes, and snippets.

@khalidwilliams

khalidwilliams/2006 final project submission.md

Created November 10, 2020 00:05
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save khalidwilliams/ae2ea891ac60b9a10f06f7debff24a32 to your computer and use it in GitHub Desktop.
Save khalidwilliams/ae2ea891ac60b9a10f06f7debff24a32 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
2006 final project submission.md

Final Project Submission

Rocky Balboa victoriously cheering

You did it!! Congratulations on getting through the Mod 3 projects.

There are a lot of y'all, and not a lot of time to give detailed feedback on every piece of all your projects. So please comment down below with

  • the link to your repo
  • the link to your deployment (if you have one, not stress if not)
  • 1 - 2 dpecific areas of the code you want feedback on.

Thank you, and great work!

@timkeresey
Copy link

Repo

  • async JS organization and testing

@stacyp2006
Copy link

Repo

Testing: specifically, whether it is thorough enough and why my catches are logging in the terminal.
Architecture: Organization and state management

@GreyMatteOr
Copy link

Repo
Deployed

@BlakeDonn
Copy link

BlakeDonn commented Nov 10, 2020 •
edited

repo
env api key: REACT_APP_API_KEY=FB1509FF-2D29-7C41-AD87-7E52E19A0A22795D51E2-8C6C-4F81-94A1-20C7415D8B7F

  1. Is this an acceptable use of router? (specifically the non-exact use of results page if too brief)
  2. Data flow

@taylorjohnson141
Copy link

https://github.com/taylorjohnson141/learnlo
Architecture: Is everything set up okay
Testing:Am I testing everything correctly

@BrigetteDoelp
Copy link

https://github.com/BrigetteDoelp/wayshrine-adventurer-registry

TESTING PLEASE
and also architecture! had a second guessing moment there, so i'd like to hear about how my react stuff is plz

@kathrynljackson
Copy link

PokéPlanner

Testing:

  • What did I not test that I should have?
  • How can I improve the asyn testing?

Data:

  • Where the components separated correctly?
  • Where the props passed correctly?
  • Why are the errors in the console mad at me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment