Create a gist now

Instantly share code, notes, and snippets.

Embed
function whichTransitionEvent(){
var t;
var el = document.createElement('fakeelement');
var transitions = {
'transition':'transitionend',
'MSTransition':'msTransitionEnd',
'MozTransition':'transitionend',
'WebkitTransition':'webkitTransitionEnd'
}
for(t in transitions){
if( el.style[t] !== undefined ){
return transitions[t];
}
}
}
@MikhailTatsky

This comment has been minimized.

Show comment
Hide comment
@MikhailTatsky

MikhailTatsky Feb 18, 2013

Two questions, please.

1 -
Is it really needed to do fake element?
document.body has some bugs or wrong behavior?

2 - WebkitTransition. it is strange that in console present only lower case webkitTransition.
And from IE9 this works el.style.setProperty("-webkit-transition", "left 2s linear");
http://jsfiddle.net/7b4VZ/3/

Two questions, please.

1 -
Is it really needed to do fake element?
document.body has some bugs or wrong behavior?

2 - WebkitTransition. it is strange that in console present only lower case webkitTransition.
And from IE9 this works el.style.setProperty("-webkit-transition", "left 2s linear");
http://jsfiddle.net/7b4VZ/3/

@cubiq

This comment has been minimized.

Show comment
Hide comment
@cubiq

cubiq Apr 6, 2013

I would suggest to simply register all transitionend events for all vendors. do we really need to spoof them?

cubiq commented Apr 6, 2013

I would suggest to simply register all transitionend events for all vendors. do we really need to spoof them?

@ionutzp

This comment has been minimized.

Show comment
Hide comment
@ionutzp

ionutzp Jul 19, 2013

I have successfully used callbacks by registering the events for all browsers so i would recommend that.
eg: this.$el.on('webkitTransitionEnd transitionend msTransitionEnd oTransitionEnd', function(event) { ...

ionutzp commented Jul 19, 2013

I have successfully used callbacks by registering the events for all browsers so i would recommend that.
eg: this.$el.on('webkitTransitionEnd transitionend msTransitionEnd oTransitionEnd', function(event) { ...

@davidsm

This comment has been minimized.

Show comment
Hide comment
@davidsm

davidsm Oct 4, 2013

You shouldn't register all events. The reason for this is that at least Chrome as of version 29 will fire off both webkitTransitionEnd and transitionend. So your function will fire twice.

davidsm commented Oct 4, 2013

You shouldn't register all events. The reason for this is that at least Chrome as of version 29 will fire off both webkitTransitionEnd and transitionend. So your function will fire twice.

@Hengjie

This comment has been minimized.

Show comment
Hide comment
@Hengjie

Hengjie Mar 29, 2014

The way you get around firing function twice is to add a namespace to the event name and turning them all off once one of them have been executed.

this.$el.on('webkitTransitionEnd.blah transitionend.blah msTransitionEnd.blah oTransitionEnd.blah', function(event) {
  this.$el.off(".blah");
}

Obviously, replace blah with your own namespace.

Hengjie commented Mar 29, 2014

The way you get around firing function twice is to add a namespace to the event name and turning them all off once one of them have been executed.

this.$el.on('webkitTransitionEnd.blah transitionend.blah msTransitionEnd.blah oTransitionEnd.blah', function(event) {
  this.$el.off(".blah");
}

Obviously, replace blah with your own namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment